V10.2.0/support for m49 - #142

src/Cuemon.Core/Globalization/UnM49DataContainer.cs (2)

31-47: Unreachable null check — Single() throws before stream can be null.

GetManifestResources(resourceName).Single() will throw InvalidOperationException if no element is found (or more than one), so the stream == null check on Line 34 is never reached. Consider removing the dead branch or replacing Single() with SingleOrDefault() if you want the null-check path to be reachable.

---

86-95: Bare catch swallows all exceptions.

The catch on Line 92 catches every exception type, including catastrophic ones (e.g., OutOfMemoryException). Since the intent is only to handle unsupported territories, narrow the catch to the expected exception type(s).

Proposed fix

                 try
                 {
                     regionInfo = World.Regions.FirstOrDefault(r => string.Equals(r.TwoLetterISORegionName, countryData.IsoAlpha2, StringComparison.OrdinalIgnoreCase));
                 }
-                catch
+                catch (Exception) when (regionInfo == null)
                 {
                     // Some territories may not be supported by the OS
                 }

Or more precisely, catch only the expected ArgumentException/CultureNotFoundException types.

src/Cuemon.Core/Globalization/World.cs (1)

35-51: Eager evaluation of Lazy wrappers defeats deferred loading.

Both Regions (Line 41) and StatisticalRegions (Line 51) are auto-property initializers that unwrap Lazy.Value during static construction, so the JSON resource is parsed the first time any World member is accessed — even if the caller only needs GetCultures. The Lazy<T> wrappers serve no deferral purpose here since the static constructor eagerly evaluates all field initializers in order.

This is fine if the cost is acceptable at app startup. If you'd prefer to defer the M49 load until actually needed, make StatisticalRegions delegate to the Lazy rather than capture its value:

Example

-public static IReadOnlyList<StatisticalRegionInfo> StatisticalRegions { get; } = UnM49Data.Value.Regions;
+public static IReadOnlyList<StatisticalRegionInfo> StatisticalRegions => UnM49Data.Value.Regions;

(Same approach could be applied to Regions if desired.)

src/Cuemon.Core/Globalization/StatisticalRegionInfo.cs (1)

120-122: Countries allocates a new list on every access.

Countries traverses the full descendant tree and materialises a new List<T> each time it is read. For the World node this means ~250+ items re-collected on every call, which is hidden behind a property that callers will assume is cheap. Consider caching the result (e.g., a Lazy<IReadOnlyList<…>>) or at minimum switching to a method name (GetCountries()) to signal the cost.

Caching example

+private IReadOnlyList<StatisticalRegionInfo> _countries;
+
 public IReadOnlyList<StatisticalRegionInfo> Countries =>
-    GetAllDescendants()
-        .Where(r => r.Kind == StatisticalRegionKind.CountryOrTerritory)
-        .ToList();
+    _countries ??= GetAllDescendants()
+        .Where(r => r.Kind == StatisticalRegionKind.CountryOrTerritory)
+        .ToList();

.nuget/Cuemon.Data.Integrity/PackageReleaseNotes.txt (1)

1-5: Release notes for 10.2.0 look incomplete.

The PR adds UN M.49 statistical region support and new public APIs, but the 10.2.0 notes only mention dependency upgrades. Please add a bullet for the UN M.49 feature so users see the change in package release notes.

.nuget/Cuemon.Extensions.Data/PackageReleaseNotes.txt (1)

1-6: LGTM! Format and content are consistent.

The release notes entry follows the established pattern perfectly—version, availability, and ALM section with dependency upgrades. The minor version bump (10.1.2 → 10.2.0) appropriately signals that new capabilities are available in the ecosystem (UN M.49 support in Cuemon.Core).

📝 Optional enhancement: Consider mentioning UN M.49 support

If Cuemon.Extensions.Data exposes or benefits from the new UN M.49 statistical region features added to Cuemon.Core, you could optionally add a note under the ALM section:

 # ALM
 - CHANGED Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs)
+- NOTE Dependency upgrade enables access to new UN M.49 statistical regions support (via Cuemon.Core 10.2.0)

However, given that most releases in this file use the generic dependency message, the current version is perfectly acceptable.

.nuget/Cuemon.Extensions.DependencyInjection/PackageReleaseNotes.txt (1)

1-6: Consider adding ecosystem context for users.

While the dependency update note is accurate for this package, users might benefit from a brief mention that this release aligns with Cuemon 10.2.0, which adds UN M.49 statistical region support in related packages (Cuemon.Core, Cuemon.Globalization). This would provide helpful context without overstating changes to this specific package.

Example addition:

 # ALM
 - CHANGED Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs)
+- NOTE This release aligns with Cuemon 10.2.0, which adds UN M.49 statistical region and country support in core packages

.nuget/Cuemon.Data.SqlClient/PackageReleaseNotes.txt (1)

1-5: Consider making release notes more informative.

While the current format is consistent, the identical ALM note about dependency upgrades appears in 10 consecutive releases (10.1.2 through 9.0.1). For better user experience, consider either specifying which dependencies were upgraded and to which versions, or omitting the note when changes are identical to the previous release.

.nuget/Cuemon.Core/PackageReleaseNotes.txt (1)

12-12: Clarify the GetStatisticalRegions method description.

The description states "retrieves a list of statistical regions for a given UN M.49 country code," which is ambiguous. Consider clarifying:

• If this method returns parent regions containing the specified country, the description should state "retrieves all parent statistical regions for a given UN M.49 country code"
• If the parameter accepts both region and country codes, consider using "UN M.49 code" instead of "country code"

src/Cuemon.Core/Globalization/StatisticalRegionInfo.cs (2)

120-122: Countries materializes a full subtree traversal on every access.

.ToList() forces a complete recursive enumeration and allocation each time the property is read. For the World node this walks ~250 countries per call. Either cache the result (invalidating on AddChild) or drop .ToList() to keep it lazy and let consumers materialize if needed.

Option A – keep it lazy

-        public IEnumerable<StatisticalRegionInfo> Countries => GetAllDescendants()
-            .Where(r => r.Kind == StatisticalRegionKind.CountryOrTerritory)
-            .ToList();
+        public IEnumerable<StatisticalRegionInfo> Countries => GetAllDescendants()
+            .Where(r => r.Kind == StatisticalRegionKind.CountryOrTerritory);

---

110-110: Children exposes the mutable backing list by reference.

Callers can cast the returned IEnumerable<StatisticalRegionInfo> to List<StatisticalRegionInfo> and mutate it, bypassing the AddChild guard. Since the constructors are internal this risk is limited, but wrapping with AsReadOnly() would be safer.

Suggested fix

-        public IEnumerable<StatisticalRegionInfo> Children => _children;
+        public IEnumerable<StatisticalRegionInfo> Children => _children.AsReadOnly();

src/Cuemon.Core/Globalization/UnM49DataContainer.cs (1)

89-125: Hand-rolled CSV parser — consider noting its limitations.

The parser handles quoted fields and escaped double-quotes, which covers standard RFC 4180. Just be aware it doesn't handle newlines embedded within quoted fields. If the CSV data is controlled (embedded resource), this is likely fine, but worth a comment.